Fix: Specify Istio version for Waypoint feature #239
Conversation
Signed-off-by: Tom <[email protected]>
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @Flying-Tom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the development setup documentation by specifying Istio version 1.24.0 for installation, which is crucial for compatibility with the Waypoint feature. It also introduces a clear warning about the maximum supported Istio version (1.25) when utilizing Waypoint, thereby preventing potential issues for developers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Istio installation instructions in the development guide to use a specific version (1.24.0) which is compatible with the Waypoint feature. This is a good improvement as it fixes an issue where the documentation was inconsistent. The changes are also applied to the Chinese translation. I've added a suggestion to improve the clarity of the note about version compatibility.
i18n/zh/docusaurus-plugin-content-docs/current/setup/develop-with-kind.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Tom <[email protected]>
|
@Flying-Tom We should also figure out how istio makes it uncompatible with kmesh |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Istio version specifications across documentation files to ensure compatibility with the Waypoint feature. It sets a specific Istio version (1.24.0/1.25.0) and adds version limitation notes for Waypoint functionality.
- Specifies exact Istio versions in installation commands (1.24.0 for istioctl, 1.25.0 for Helm)
- Updates version compatibility notes to indicate tested ranges (1.22-1.25)
- Adds warnings about Waypoint feature requiring Istio versions no higher than 1.25
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/setup/quick-start.md | Updates Helm installation to specify version 1.25.0 and adds Waypoint version limitation note |
| docs/setup/develop-with-kind.md | Specifies Istio 1.24.0 for istioctl installation and adds Waypoint version warning |
| i18n/zh/docusaurus-plugin-content-docs/current/setup/quick-start.md | Chinese translation of quick-start changes |
| i18n/zh/docusaurus-plugin-content-docs/current/setup/develop-with-kind.md | Chinese translation of develop-with-kind changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Tom <[email protected]>
Flying-Tom
force-pushed
the
istio-version
branch
from
f576bc2 to
ac671f2
Compare
|
@LiZhenCheng9527 any fixup needed? |
|
Now Kmesh support istio is 1.24, 1.25 and 1.26. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Set the Istio version to 1.24.0 to ensure compatibility with the Waypoint feature and provide a note regarding version limitations.